Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROCS-4577] Remove ECSEC2Suite embed from ECSEC2CoreAgentSuite struct #31800

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[PROCS-4577] Remove ECSEC2Suite embed from ECSEC2CoreAgentSuite struct #31800

merged 1 commit into from
Dec 5, 2024

Conversation

daniel-taf
Copy link
Contributor

@daniel-taf daniel-taf commented Dec 5, 2024 •
edited
Loading

What does this PR do?

Removes the ECSEC2Suite embed in the ECSEC2CoreAgentSuite as it resulted in the process agent tests being run. Example from failed job:

--- FAIL: TestECSEC2CoreAgentSuite (690.69s)
    --- PASS: TestECSEC2CoreAgentSuite/TestProcessCheck (40.00s)
    --- FAIL: TestECSEC2CoreAgentSuite/TestProcessCheckInCoreAgent (10.00s)

Motivation

Flakes

Describe how you validated your changes

Ran the test to see that only the Core Agent test was run

=== RUN   TestECSEC2CoreAgentSuite/TestProcessCheckInCoreAgent
    suite.go:280: No change in provisioners, skipping environment update
--- PASS: TestECSEC2CoreAgentSuite (649.72s)
    --- PASS: TestECSEC2CoreAgentSuite/TestProcessCheckInCoreAgent (10.15s)

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/processes short review PR is simple enough to be reviewed quickly labels Dec 5, 2024
@daniel-taf daniel-taf added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog labels Dec 5, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50399211 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50399211 --os-family=ubuntu

Note: This applies to commit 48c8541

@daniel-taf daniel-taf changed the title Fix ECSEC2CoreAgentSuite [PROCS-4577] Remove Process Agent tests from ECSEC2CoreAgentSuite Dec 5, 2024
@daniel-taf daniel-taf changed the title [PROCS-4577] Remove Process Agent tests from ECSEC2CoreAgentSuite [PROCS-4577] Remove Process Agent tests from ECSEC2CoreAgentSuite Dec 5, 2024
@daniel-taf daniel-taf changed the title [PROCS-4577] Remove Process Agent tests from ECSEC2CoreAgentSuite [PROCS-4577] Remove ECSEC2Suite embed from ECSEC2CoreAgentSuite Dec 5, 2024
@daniel-taf daniel-taf changed the title [PROCS-4577] Remove ECSEC2Suite embed from ECSEC2CoreAgentSuite [PROCS-4577] Remove ECSEC2Suite embed from ECSEC2CoreAgentSuite struct Dec 5, 2024
@daniel-taf daniel-taf marked this pull request as ready for review December 5, 2024 16:03
@daniel-taf daniel-taf requested a review from a team as a code owner December 5, 2024 16:03
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9a359283-a9bc-4053-9deb-6849e7ea7642

Baseline: 013c572
Comparison: 48c8541
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +4.11 [+1.14, +7.08] 1 Logs
➖ otel_to_otel_logs ingress throughput +1.35 [+0.64, +2.06] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.18 [-0.62, +0.98] 1 Logs
➖ file_tree memory utilization +0.15 [+0.01, +0.29] 1 Logs
➖ quality_gate_idle memory utilization +0.05 [+0.00, +0.09] 1 Logs bounds checks dashboard
➖ file_to_blackhole_100ms_latency egress throughput +0.03 [-0.69, +0.76] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.03 [-0.83, +0.89] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.66] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.09] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.04 [-0.81, +0.72] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.28 [-0.75, +0.18] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.83 [-0.93, -0.73] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.96 [-1.68, -0.23] 1 Logs
➖ quality_gate_idle_all_features memory utilization -2.22 [-2.32, -2.12] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@daniel-taf
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 5, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-05 16:32:55 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit 97d29fb into main Dec 5, 2024
225 of 228 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daniel.tafoya/fix-ecs-test-split branch December 5, 2024 16:55
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiyu wiyu wiyu approved these changes

@robertjli robertjli robertjli approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/processes
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-taf @robertjli @wiyu